[ https://issues.apache.org/jira/browse/HBASE-28716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17868264#comment-17868264 ]
Hudson commented on HBASE-28716: -------------------------------- Results for branch branch-2 [build #1113 on builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/1113/]: (x) *{color:red}-1 overall{color}* ---- details (if available): (/) {color:green}+1 general checks{color} -- For more information [see general report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/1113/General_20Nightly_20Build_20Report/] (/) {color:green}+1 jdk8 hadoop2 checks{color} -- For more information [see jdk8 (hadoop2) report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/1113/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/] (x) {color:red}-1 jdk8 hadoop3 checks{color} -- For more information [see jdk8 (hadoop3) report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/1113/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/] (x) {color:red}-1 jdk11 hadoop3 checks{color} -- For more information [see jdk11 report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/1113/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/] (x) {color:red}-1 jdk17 hadoop3 checks{color} -- For more information [see jdk17 report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/1113/JDK17_20Nightly_20Build_20Report_20_28Hadoop3_29/] (/) {color:green}+1 source release artifact{color} -- See build output for details. (/) {color:green}+1 client integration test{color} > Users of QuotaRetriever should pass an existing connection > ---------------------------------------------------------- > > Key: HBASE-28716 > URL: https://issues.apache.org/jira/browse/HBASE-28716 > Project: HBase > Issue Type: Bug > Components: Admin > Reporter: Charles Connell > Assignee: Charles Connell > Priority: Minor > Labels: pull-request-available > Fix For: 4.0.0-alpha-1, 2.7.0, 3.0.0-beta-2, 2.6.1, 2.5.11 > > > Every call to {{HBaseAdmin#getQuota()}} opens a new {{Connection}}, and then > closes it. As far as I can tell, this is pointless, since it could use the > existing {{Connection}} object held by the {{HBaseAdmin}}. If you have a > custom RpcClient (like we do at Hubspot), new connections have an expense > that we'd rather not pay unnecessarily. I'll submit a PR that addresses this > situation and similar ones. -- This message was sent by Atlassian Jira (v8.20.10#820010)