DieterDP-ng commented on code in PR #6130:
URL: https://github.com/apache/hbase/pull/6130#discussion_r1696581571
##########
hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/impl/BackupCommands.java:
##########
@@ -335,8 +335,8 @@ public void execute() throws IOException {
if (cmdline.hasOption(OPTION_YARN_QUEUE_NAME)) {
Review Comment:
I suggest moving this block to before the `super.execute();` that creates
the connection. That way, you can directly update the conf using `getConf()`.
Won't have any change in outcome, but feels a bit simpler.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
