NihalJain commented on PR #6127: URL: https://github.com/apache/hbase/pull/6127#issuecomment-2259884410
Hi just updating how I have been testing out this version bump. Following are the things i have tested: 1. HBase Shell sanity commands in a standalone on Mac and distributed cluster (with/without kerberos, both cases) on RHEL - Tested in distributed mode by backporting changes to 2.6.0 code fork - While have tested in standalone mode with master OS code itself 2. HBase Shell Help command, works fine! 3. JRuby version check - <img width="202" alt="Screenshot 2024-07-29 at 5 06 38 PM" src="https://github.com/user-attachments/assets/ad8a8f8d-d678-4da1-b69e-526bd5c5c1a4";> 4. Shell echo and then pipe command and check exit code. - Covers https://issues.apache.org/jira/browse/HBASE-18393 5. Shell top level defs to load a scipt inside shell. - Covers https://issues.apache.org/jira/browse/HBASE-26269 6. Shell echo then pipe and run script in background. - Covers https://issues.apache.org/jira/browse/HBASE-26772 7. Shell error handling cases. - Covers https://issues.apache.org/jira/browse/HBASE-26751, https://issues.apache.org/jira/browse/HBASE-26741 and https://issues.apache.org/jira/browse/HBASE-26880 8. Shell exit code in case of error. - Covers https://issues.apache.org/jira/browse/HBASE-26741 9. Run other existing scripts like `get-active-master.rb`, `replication/copy_tables_desc.rb`, `draining_servers.rb` and ensure no error. 10. Test basic ruby code, works fine! ``` puts "Enter first value: " num1=gets.chomp.to_i puts "Enter second value: " num2=gets.chomp.to_i sum=num1+num2 puts "The sum is #{sum}." ``` 11. Test basic HBase ruby code, works fine, with removal of import ``` java_import 'org.apache.hadoop.hbase.HBaseConfiguration' java_import 'org.apache.hadoop.hbase.client.HTable' java_import 'org.apache.hadoop.hbase.client.Scan' java_import 'org.apache.hadoop.hbase.util.Bytes' config = HBaseConfiguration.create() connection = ConnectionFactory.createConnection(config) table_name = TableName.valueOf("nj:test") table = connection.getTable(table_name) scan = Scan.new() scanner = table.getScanner(scan) iterator = scanner.iterator() while iterator.hasNext() result = iterator.next() puts Bytes.toString(result.getRow()) end scanner.close() connection.close() ``` - Here, there's a breaking change import commands no longer work, so we ought to use java_import 12. Tested TAB behavior. Now instead of asking to display all possible options, it just picks up some command from history 13. Test Autocomplete, works fine for most commands - <img width="358" alt="Screenshot 2024-07-29 at 5 07 08 PM" src="https://github.com/user-attachments/assets/f10d9884-c0e2-43ab-88f8-f47c6b397f4f";> 14. Test Autocomplete in a scenario where we try switching to command 'disable_all' by typing 'disable' and then TAB - Buggy, command hangs and we are not able to take input Based on point 12 and 14, I suggest to disable colorize and auto_complete which are by default enabled in JRuby 9.4.8.0 and is very buggy Or we could document steps on how to disable it via .irbrc. See https://github.com/ruby/irb/issues/445 and https://github.com/ruby/irb/issues/351. Will update PR based on how others feel. Based on point 11, we may need to add removal of import for custom ruby scripts. Rest all looks good to me. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
