2005hithlj commented on code in PR #6131:
URL: https://github.com/apache/hbase/pull/6131#discussion_r1698430916


##########
hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/impl/BackupCommands.java:
##########
@@ -142,6 +142,12 @@ public void execute() throws IOException {
         throw new IOException(INCORRECT_USAGE);
       }
 
+      if (cmdline.hasOption(OPTION_YARN_QUEUE_NAME)) {
+        String queueName = cmdline.getOptionValue(OPTION_YARN_QUEUE_NAME);
+        // Set MR job queuename to configuration
+        getConf().set("mapreduce.job.queuename", queueName);

Review Comment:
   Currently, all the parameter parsing for the backup command is done in 
BackupCommands.java. If we separately move the parsing of the yarn queue to 
BackupDriver.java, the code might not be as elegant.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to