Apache9 commented on code in PR #6148:
URL: https://github.com/apache/hbase/pull/6148#discussion_r1713827713
##########
hbase-asyncfs/src/main/java/org/apache/hadoop/hbase/io/asyncfs/FanOutOneBlockAsyncDFSOutputHelper.java:
##########
@@ -474,7 +475,7 @@ private static FanOutOneBlockAsyncDFSOutput
createOutput(DistributedFileSystem d
new HashSet<>(excludeDatanodeManager.getExcludeDNs().keySet());
for (int retry = 0;; retry++) {
LOG.debug("When create output stream for {}, exclude list is {},
retry={}", src,
- toExcludeNodes, retry);
+
toExcludeNodes.stream().map(DatanodeInfo::getHostName).collect(Collectors.toSet()),
retry);
Review Comment:
Let's introduce a helper method to convert DatanodeInfo to the prefer text
format? I think better to include both host name and ip, and also port in the
output.
And since this will be kinda expensive, we'd better put this into a
LOG.isDebugEnabled if condition.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
