Umeshkumar9414 commented on code in PR #6129:
URL: https://github.com/apache/hbase/pull/6129#discussion_r1717473031
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/handler/UnassignRegionHandler.java:
##########
@@ -63,20 +63,25 @@ public class UnassignRegionHandler extends EventHandler {
private boolean evictCache;
+ // active time of the master that sent this unassign request
+ private final long initiatingMasterActiveTime;
+
public UnassignRegionHandler(HRegionServer server, String encodedName, long
closeProcId,
boolean abort, @Nullable ServerName destination, EventType eventType) {
- this(server, encodedName, closeProcId, abort, destination, eventType,
false);
+ this(server, encodedName, closeProcId, abort, destination, eventType, -1,
false);
Review Comment:
I am not sure if anyone is using this. At least in the code, I didn't see
any usage of this. As I was not aware I didn't change the signature. -1 is safe
as it will not block the procedure reporting as -1 will be the smallest active
code.
Should I follow the aggressive approach and ask for an argument and pass
that further? I think that would be good. Let me change to that approch
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/master/MasterRpcServices.java:
##########
@@ -2567,6 +2583,18 @@ public ReportProcedureDoneResponse
reportProcedureDone(RpcController controller,
return ReportProcedureDoneResponse.getDefaultInstance();
}
+ private void throwOnOldMasterStartCode(long procId, long
initiatingMasterActiveTime)
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
