jhungund commented on code in PR #6182:
URL: https://github.com/apache/hbase/pull/6182#discussion_r1735572076
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFilePreadReader.java:
##########
@@ -34,12 +34,14 @@
public class HFilePreadReader extends HFileReaderImpl {
private static final Logger LOG =
LoggerFactory.getLogger(HFileReaderImpl.class);
+ private static final int WAIT_TIME_FOR_CACHE_INITIALIZATION = 120 * 60 *
1000;
Review Comment:
No, actually we have seen that it takes around 4 minutes. I will reduce this
wait time to 10 mins.
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/CombinedBlockCache.java:
##########
@@ -507,4 +507,18 @@ public int evictBlocksRangeByHfileName(String hfileName,
long initOffset, long e
return l1Cache.evictBlocksRangeByHfileName(hfileName, initOffset,
endOffset)
+ l2Cache.evictBlocksRangeByHfileName(hfileName, initOffset, endOffset);
}
+
+ @Override
+ public boolean waitForCacheInitialization(long timeout) {
+ return (this.l2Cache instanceof BucketCache)
Review Comment:
ack
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
