jhungund commented on code in PR #6183:
URL: https://github.com/apache/hbase/pull/6183#discussion_r1736106606
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/BucketCache.java:
##########
@@ -1358,8 +1397,14 @@ void persistToFile() throws IOException {
}
File tempPersistencePath = new File(persistencePath +
EnvironmentEdgeManager.currentTime());
try (FileOutputStream fos = new FileOutputStream(tempPersistencePath,
false)) {
- fos.write(ProtobufMagic.PB_MAGIC);
- BucketProtoUtils.toPB(this).writeDelimitedTo(fos);
+ if (!enableChunkedPersistence) {
+ LOG.debug("Persist in old persistence format.");
+ fos.write(ProtobufMagic.PB_MAGIC);
+ BucketProtoUtils.toPB(this).writeDelimitedTo(fos);
+ } else {
+ LOG.debug("Persist in new chunked persistence format.");
+ persistChunkedBackingMap(fos);
+ }
Review Comment:
The idea was that if we run into some bugs initially with the new
implementation, we can revert to the old implementation which can still work
for smaller DBs. Let me remove the config and make new version default.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
