jhungund commented on code in PR #6182:
URL: https://github.com/apache/hbase/pull/6182#discussion_r1736473822


##########
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/BucketCache.java:
##########


Review Comment:
   ack



##########
hbase-server/src/test/java/org/apache/hadoop/hbase/io/hfile/bucket/TestRecoveryPersistentBucketCache.java:
##########
@@ -143,7 +147,16 @@ public void testBucketCacheEvictByHFileAfterRecovery() 
throws Exception {
 
   private void waitUntilFlushedToBucket(BucketCache cache, BlockCacheKey 
cacheKey)
     throws InterruptedException {
-    while (!cache.backingMap.containsKey(cacheKey) || 
cache.ramCache.containsKey(cacheKey)) {
+    try {
+      long timeout = 120000;
+      while (!cache.backingMap.containsKey(cacheKey) || 
cache.ramCache.containsKey(cacheKey)) {
+        Thread.sleep(100);
+        if (timeout <= 0) {
+          break;
+        }
+        timeout -= 100;
+      }

Review Comment:
   ack



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to