ndimiduk commented on code in PR #6067:
URL: https://github.com/apache/hbase/pull/6067#discussion_r1740494283
##########
hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/impl/BackupSystemTable.java:
##########
@@ -1885,6 +1887,13 @@ private String cellKeyToBackupSetName(Cell current) {
return Bytes.toString(data).substring(SET_KEY_PREFIX.length());
}
+ private void executeBufferedMutations(Table table, List<? extends Mutation>
mutations)
Review Comment:
This helper function is now kinda weird. I think that you can replace all
the above `try (Table table = ...) { ... }` with `try (BufferedMutator bm =
...) { ... }`. On quick glance, you never use the `table` instance other than
to get the name in order to create the `BufferedMutator` instance.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
