charlesconnell commented on code in PR #6167:
URL: https://github.com/apache/hbase/pull/6167#discussion_r1742014055
##########
hbase-endpoint/src/main/java/org/apache/hadoop/hbase/client/coprocessor/AsyncAggregationClient.java:
##########
@@ -106,6 +126,31 @@ public synchronized void onComplete() {
finished = true;
future.complete(getFinalResult());
}
+
+ @Override
+ public ServiceCaller<AggregateService, AggregateResponse>
+ getNextCallable(AggregateResponse response, RegionInfo region) {
+ if (!response.hasNextChunkStartRow()) {
+ return null;
+ }
+ return (stub, controller, rpcCallback) -> {
+ AggregateRequest.Builder updatedRequest =
AggregateRequest.newBuilder(originalRequest);
+ updatedRequest.setScan(originalRequest.getScan().toBuilder()
+ .setStartRow(response.getNextChunkStartRow()).build());
+ if (log.isTraceEnabled()) {
+ log.trace("Got incomplete result {} for original scan {}. Sending
new request {}.",
Review Comment:
good point, I'll change it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
