1458451310 commented on code in PR #6008:
URL: https://github.com/apache/hbase/pull/6008#discussion_r1744994883
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java:
##########
@@ -1453,6 +1453,15 @@ public Optional<CompactionContext> requestCompaction(int
priority,
// Before we do compaction, try to get rid of unneeded files to simplify
things.
removeUnneededFiles();
+ if (this.region.getTableDescriptor().isSkipMergingCompaction()) {
+ if (!conf.getBoolean("hbase.store.delete.expired.storefile", true)) {
Review Comment:
> Also could you refactor 'hbase.store.delete.expired.storefile' into a
variable along with its default value? I see only one usage of this in the code
base, apart from testcode.
I have changed based on your suggestion. Please review again when you have
time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
