DieterDP-ng commented on code in PR #6195:
URL: https://github.com/apache/hbase/pull/6195#discussion_r1747149628
##########
hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/master/BackupLogCleaner.java:
##########
@@ -80,8 +81,13 @@ public void init(Map<String, Object> params) {
}
}
- private Map<Address, Long> getServersToOldestBackupMapping(List<BackupInfo>
backups)
- throws IOException {
+ private Map<Address, Long> getServerToLastBackupTs(List<BackupInfo> backups)
throws IOException {
Review Comment:
I'm pro naming this `newest`.
Realizing now that this tracks the newest backup, it means this logic also
contains a bug: it does not keep track of multi-root backups. I.e. if there are
2 backups roots R1 and R2, where R1 was backed up 1 week ago, and R2 today, the
WALS needed for R1 could be deleted (= data loss).
Perhaps log that as a separate issue?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
