DieterDP-ng commented on code in PR #6040:
URL: https://github.com/apache/hbase/pull/6040#discussion_r1761686906
##########
hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/master/BackupLogCleaner.java:
##########
@@ -160,7 +167,7 @@ public boolean isStopped() {
return this.stopped;
}
- protected static boolean canDeleteFile(Map<Address, Long>
addressToLastBackupMap, Path path) {
+ protected static boolean canDeleteFile(Map<Address, Long>
addressToLatestUnusedLogTs, Path path) {
Review Comment:
A "newest unused log timestamp" also feels weird. I'll just rename it to a
"boundary" to avoid the newest/oldest confusion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
