NihalJain commented on PR #6258: URL: https://github.com/apache/hbase/pull/6258#issuecomment-2356581486
Supersedes PR #6249, also see https://github.com/apache/hbase/pull/6249#issuecomment-2353798881 **Change Summary** - Added a new module called `hbase-diagnostics` (as suggested by @stoty) - _Question_: Any better names? - Moved all the targeted tools we intend to move (i.e. `PerformanceEvaluation`, `LoadTestTool`, `HFilePerformanceEvaluation`, `ScanPerformanceEvaluation` and `LoadBalancerPerformanceEvaluation`) as part of this task to main of `hbase-diagnostics` along with all related classes: - _Question_: Anything else which we need to handle? - Moved following classses to their corresponding modules' main code: - `RandomDistribution` - `KeyProviderForTesting` - `LoadTestKVGenerator` - `FilterAllFilter` - Added a new util `DiagnosticToolsCommonUtils` and moved method required to `loginAndReturnUGI()` from `HBaseKerberosUtils` - Added a new util `LoadTestUtil` and moved all load test related code from `HFileTestUtil` and `HBaseTestingUtil` to here - _Question_: Should we merge this to `DiagnosticToolsCommonUtils`? - Copied `generateData()` from `PerformanceEvaluation` in `TestHFileOutputFormat2` to break cyclic dependency - Added `@InterfaceAudience.Private` to all classes moved from test code to main - Replaced `UTIL.getConfiguration()` with `HBaseConfiguration.create()` in `LoadBalancerPerformanceEvaluation` Also ran basic commands for sanity of above 5 tools in a standalone local cluster. Newly generated jars' content: ``` hbase % jar -tf hbase-4.0.0-alpha-1-SNAPSHOT/lib/hbase-diagnostics-4.0.0-alpha-1-SNAPSHOT.jar META-INF/MANIFEST.MF META-INF/ org/ org/apache/ org/apache/hadoop/ org/apache/hadoop/hbase/ org/apache/hadoop/hbase/master/ org/apache/hadoop/hbase/master/balancer/ org/apache/hadoop/hbase/util/ org/apache/hadoop/hbase/util/test/ META-INF/maven/ META-INF/maven/org.apache.hbase/ META-INF/maven/org.apache.hbase/hbase-diagnostics/ META-INF/DEPENDENCIES META-INF/LICENSE META-INF/NOTICE org/apache/hadoop/hbase/HFilePerformanceEvaluation$1.class org/apache/hadoop/hbase/HFilePerformanceEvaluation$2.class org/apache/hadoop/hbase/HFilePerformanceEvaluation$3.class org/apache/hadoop/hbase/HFilePerformanceEvaluation$4.class org/apache/hadoop/hbase/HFilePerformanceEvaluation$GaussianRandomReadBenchmark.class org/apache/hadoop/hbase/HFilePerformanceEvaluation$ReadBenchmark.class org/apache/hadoop/hbase/HFilePerformanceEvaluation$RowOrientedBenchmark.class org/apache/hadoop/hbase/HFilePerformanceEvaluation$SequentialReadBenchmark.class org/apache/hadoop/hbase/HFilePerformanceEvaluation$SequentialWriteBenchmark.class org/apache/hadoop/hbase/HFilePerformanceEvaluation$UniformRandomReadBenchmark.class org/apache/hadoop/hbase/HFilePerformanceEvaluation$UniformRandomSmallScan.class org/apache/hadoop/hbase/HFilePerformanceEvaluation.class org/apache/hadoop/hbase/PerformanceEvaluation$1$1.class org/apache/hadoop/hbase/PerformanceEvaluation$1.class org/apache/hadoop/hbase/PerformanceEvaluation$AppendTest.class org/apache/hadoop/hbase/PerformanceEvaluation$AsyncRandomReadTest.class org/apache/hadoop/hbase/PerformanceEvaluation$AsyncRandomWriteTest.class org/apache/hadoop/hbase/PerformanceEvaluation$AsyncScanTest.class org/apache/hadoop/hbase/PerformanceEvaluation$AsyncSequentialReadTest.class org/apache/hadoop/hbase/PerformanceEvaluation$AsyncSequentialWriteTest.class org/apache/hadoop/hbase/PerformanceEvaluation$AsyncTableTest.class org/apache/hadoop/hbase/PerformanceEvaluation$AsyncTest.class org/apache/hadoop/hbase/PerformanceEvaluation$BufferedMutatorTest.class org/apache/hadoop/hbase/PerformanceEvaluation$CASTableTest.class org/apache/hadoop/hbase/PerformanceEvaluation$CheckAndDeleteTest.class org/apache/hadoop/hbase/PerformanceEvaluation$CheckAndMutateTest.class org/apache/hadoop/hbase/PerformanceEvaluation$CheckAndPutTest.class org/apache/hadoop/hbase/PerformanceEvaluation$CleanMetaTest.class org/apache/hadoop/hbase/PerformanceEvaluation$CmdDescriptor.class org/apache/hadoop/hbase/PerformanceEvaluation$Counter.class org/apache/hadoop/hbase/PerformanceEvaluation$EvaluationMapTask$1.class org/apache/hadoop/hbase/PerformanceEvaluation$EvaluationMapTask.class org/apache/hadoop/hbase/PerformanceEvaluation$FilteredScanTest.class org/apache/hadoop/hbase/PerformanceEvaluation$IncrementTest.class org/apache/hadoop/hbase/PerformanceEvaluation$MetaRandomReadTest.class org/apache/hadoop/hbase/PerformanceEvaluation$MetaTest.class org/apache/hadoop/hbase/PerformanceEvaluation$MetaWriteTest.class org/apache/hadoop/hbase/PerformanceEvaluation$RandomDeleteTest.class org/apache/hadoop/hbase/PerformanceEvaluation$RandomReadTest.class org/apache/hadoop/hbase/PerformanceEvaluation$RandomScanWithRange10000Test.class org/apache/hadoop/hbase/PerformanceEvaluation$RandomScanWithRange1000Test.class org/apache/hadoop/hbase/PerformanceEvaluation$RandomScanWithRange100Test.class org/apache/hadoop/hbase/PerformanceEvaluation$RandomScanWithRange10Test.class org/apache/hadoop/hbase/PerformanceEvaluation$RandomScanWithRangeTest.class org/apache/hadoop/hbase/PerformanceEvaluation$RandomSeekScanTest.class org/apache/hadoop/hbase/PerformanceEvaluation$RandomWriteTest.class org/apache/hadoop/hbase/PerformanceEvaluation$ReverseScanTest.class org/apache/hadoop/hbase/PerformanceEvaluation$RunResult.class org/apache/hadoop/hbase/PerformanceEvaluation$ScanTest.class org/apache/hadoop/hbase/PerformanceEvaluation$SequentialDeleteTest.class org/apache/hadoop/hbase/PerformanceEvaluation$SequentialReadTest.class org/apache/hadoop/hbase/PerformanceEvaluation$SequentialWriteTest.class org/apache/hadoop/hbase/PerformanceEvaluation$Status.class org/apache/hadoop/hbase/PerformanceEvaluation$TableTest.class org/apache/hadoop/hbase/PerformanceEvaluation$Test.class org/apache/hadoop/hbase/PerformanceEvaluation$TestBase.class org/apache/hadoop/hbase/PerformanceEvaluation$TestOptions.class org/apache/hadoop/hbase/PerformanceEvaluation.class org/apache/hadoop/hbase/PerformanceEvaluationCommons.class org/apache/hadoop/hbase/ScanPerformanceEvaluation$MyMapper.class org/apache/hadoop/hbase/ScanPerformanceEvaluation$ScanCounter.class org/apache/hadoop/hbase/ScanPerformanceEvaluation.class org/apache/hadoop/hbase/master/balancer/LoadBalancerPerformanceEvaluation.class org/apache/hadoop/hbase/util/DiagnosticToolsCommonUtils.class org/apache/hadoop/hbase/util/LoadTestDataGeneratorWithMOB.class org/apache/hadoop/hbase/util/LoadTestDataGeneratorWithTags.class org/apache/hadoop/hbase/util/LoadTestTool$1.class org/apache/hadoop/hbase/util/LoadTestTool$WorkerThread.class org/apache/hadoop/hbase/util/LoadTestTool.class org/apache/hadoop/hbase/util/LoadTestUtil.class org/apache/hadoop/hbase/util/MultiThreadedAction$DefaultDataGenerator.class org/apache/hadoop/hbase/util/MultiThreadedAction$ProgressReporter.class org/apache/hadoop/hbase/util/MultiThreadedAction.class org/apache/hadoop/hbase/util/MultiThreadedReader$HBaseReaderThread.class org/apache/hadoop/hbase/util/MultiThreadedReader.class org/apache/hadoop/hbase/util/MultiThreadedReaderWithACL$HBaseReaderThreadWithACL$1.class org/apache/hadoop/hbase/util/MultiThreadedReaderWithACL$HBaseReaderThreadWithACL.class org/apache/hadoop/hbase/util/MultiThreadedReaderWithACL.class org/apache/hadoop/hbase/util/MultiThreadedUpdater$1.class org/apache/hadoop/hbase/util/MultiThreadedUpdater$HBaseUpdaterThread.class org/apache/hadoop/hbase/util/MultiThreadedUpdater.class org/apache/hadoop/hbase/util/MultiThreadedUpdaterWithACL$HBaseUpdaterThreadWithACL$1.class org/apache/hadoop/hbase/util/MultiThreadedUpdaterWithACL$HBaseUpdaterThreadWithACL$MutateAccessAction.class org/apache/hadoop/hbase/util/MultiThreadedUpdaterWithACL$HBaseUpdaterThreadWithACL.class org/apache/hadoop/hbase/util/MultiThreadedUpdaterWithACL.class org/apache/hadoop/hbase/util/MultiThreadedWriter$HBaseWriterThread.class org/apache/hadoop/hbase/util/MultiThreadedWriter.class org/apache/hadoop/hbase/util/MultiThreadedWriterBase$WroteKeysTracker.class org/apache/hadoop/hbase/util/MultiThreadedWriterBase.class org/apache/hadoop/hbase/util/MultiThreadedWriterWithACL$HBaseWriterThreadWithACL$WriteAccessAction.class org/apache/hadoop/hbase/util/MultiThreadedWriterWithACL$HBaseWriterThreadWithACL.class org/apache/hadoop/hbase/util/MultiThreadedWriterWithACL.class org/apache/hadoop/hbase/util/test/LoadTestDataGenerator.class org/apache/hadoop/hbase/util/test/LoadTestDataGeneratorWithACL.class META-INF/maven/org.apache.hbase/hbase-diagnostics/pom.xml META-INF/maven/org.apache.hbase/hbase-diagnostics/pom.properties ``` CC: @stoty -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
