gvprathyusha6 commented on code in PR #5939:
URL: https://github.com/apache/hbase/pull/5939#discussion_r1765426599
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionFileSystem.java:
##########
@@ -351,18 +306,19 @@ Path getStoreFilePath(final String familyName, final
String fileName) {
* @param fileName File Name
* @return The {@link StoreFileInfo} for the specified family/file
*/
- StoreFileInfo getStoreFileInfo(final String familyName, final String
fileName)
- throws IOException {
+ StoreFileInfo getStoreFileInfo(final String familyName, final String
fileName,
+ final StoreFileTracker tracker) throws IOException {
Path familyDir = getStoreDir(familyName);
return ServerRegionReplicaUtil.getStoreFileInfo(conf, fs, regionInfo,
regionInfoForFs,
- familyName, new Path(familyDir, fileName));
+ familyName, new Path(familyDir, fileName), tracker);
}
/**
* Returns true if the specified family has reference files
* @param familyName Column Family Name
* @return true if family contains reference files
*/
+ // TODO: move this to SFT
Review Comment:
this change adds, hasReferences() api in SFT, only reference of this left is
RegionSplitter, have created
[HBASE-28861](https://issues.apache.org/jira/browse/HBASE-28861) for the same,
or do we want to address as part of this change it self?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
