[ 
https://issues.apache.org/jira/browse/HBASE-28850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17882776#comment-17882776
 ] 

Andrew Kyle Purtell edited comment on HBASE-28850 at 9/18/24 9:44 PM:
----------------------------------------------------------------------

The trade off is this may change the performance of replicateEntries. Before, 
the replicateEntries call will return at the first failure. After, the 
replicateEntries will block for the entire time it takes to confirm all local 
edits in the batch are applied or failed.


was (Author: apurtell):
It makes sense not to return "success" to the source unless all edits in the 
batch are confirmed to be completed. 

The trade off is this may change the performance of replicateEntries. Before, 
the replicateEntries call will return at the first failure. After, the 
replicateEntries will block for the entire time it takes to confirm all local 
edits in the batch are applied or failed.

> Only return from ReplicationSink.replicationEntries while all background 
> tasks are finished
> -------------------------------------------------------------------------------------------
>
>                 Key: HBASE-28850
>                 URL: https://issues.apache.org/jira/browse/HBASE-28850
>             Project: HBase
>          Issue Type: Improvement
>          Components: Replication, rpc
>            Reporter: Duo Zhang
>            Assignee: Duo Zhang
>            Priority: Major
>              Labels: pull-request-available
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to