[ 
https://issues.apache.org/jira/browse/HBASE-28850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17882845#comment-17882845
 ] 

Duo Zhang commented on HBASE-28850:
-----------------------------------

{quote}
The trade off is this may change the performance of replicateEntries. Before, 
the replicateEntries call will return at the first failure. After, the 
replicateEntries will block for the entire time it takes to confirm all local 
edits in the batch are applied or failed.
{quote}

Exactly. If we want to release the resources earlier, i.e, return earlier, we'd 
better redesign the whole flow to an async way, both for normal case and error 
case. This could be a follow on issue.

> Only return from ReplicationSink.replicationEntries while all background 
> tasks are finished
> -------------------------------------------------------------------------------------------
>
>                 Key: HBASE-28850
>                 URL: https://issues.apache.org/jira/browse/HBASE-28850
>             Project: HBase
>          Issue Type: Improvement
>          Components: Replication, rpc
>            Reporter: Duo Zhang
>            Assignee: Duo Zhang
>            Priority: Major
>              Labels: pull-request-available
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to