ndimiduk commented on PR #6268: URL: https://github.com/apache/hbase/pull/6268#issuecomment-2360741518
Yeah it looks to me like some of these test changes were snuck past me in the backport of HBASE-28001 to branch-2 (#6246) and branch-2.6 (#6256). Normally under such a circumstance, I find it easier to track when we re-open the original JIRA for a revert + fixes apply (ideally), or an addendum commit (unfortunately also common). I see that there is a minor inconsistency in the method signature of `isValidRequestAttributes` across the versions. As much as possible, we want the code to match line-for-line across branches. It's a foundation of our the community's strategy for maintaining multile active release lines via backports. Let's continue as we are with the second issue. It looks to me like there will be two shapes of commit for this change. The first applies to `master` and `branch-3` only, which fixed the bug that was fixed in the branch-2 backport of HBASE-28001. The second patch applies to branch-2 and branch-2.6, which aligns the method signatures with what is present on `master`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
