[ 
https://issues.apache.org/jira/browse/HBASE-27380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17883037#comment-17883037
 ] 

Nick Dimiduk commented on HBASE-27380:
--------------------------------------

Okay, when to update this metric is not obvious to me. The `RegionStates` class 
has a `regionInTransition` Map, which is updated via delegation to 
`RegionStateNodes`. I don't think it's sufficient to update the metric upon 
removal from this map, because it appears that entries come and go from this 
map as responsibility is passed across procedures.

> RitDuration histogram metric is broken
> --------------------------------------
>
>                 Key: HBASE-27380
>                 URL: https://issues.apache.org/jira/browse/HBASE-27380
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 2.5.0, 2.6.0, 3.0.0-beta-1, 4.0.0-alpha-1
>            Reporter: Bryan Beaudreault
>            Priority: Minor
>
> Looks like the method which updates it in MetricsAssignmentManager, 
> updateRitDuration, got broken somewhere along the way. It's no longer used. 
> We should wire this back up.
> https://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/master/MetricsAssignmentManager.java#L82



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to