[
https://issues.apache.org/jira/browse/HBASE-6359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13427775#comment-13427775
]
Hadoop QA commented on HBASE-6359:
----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12538974/HBASE-6359-trunk-v1.diff
against trunk revision .
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified
tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
+1 hadoop2.0. The patch compiles against the hadoop 2.0 profile.
+1 javadoc. The javadoc tool did not generate any warning messages.
-1 javac. The applied patch generated 5 javac compiler warnings (more than
the trunk's current 4 warnings).
-1 findbugs. The patch appears to introduce 10 new Findbugs (version
1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
+1 core tests. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/2491//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/2491//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/2491//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/2491//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/2491//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/2491//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/2491//console
This message is automatically generated.
> KeyValue may return incorrect values after readFields()
> -------------------------------------------------------
>
> Key: HBASE-6359
> URL: https://issues.apache.org/jira/browse/HBASE-6359
> Project: HBase
> Issue Type: Bug
> Reporter: Dave Revell
> Assignee: Dave Revell
> Labels: noob
> Attachments: HBASE-6359-trunk-v1.diff
>
>
> When the same KeyValue object is used multiple times for deserialization
> using readFields, some methods may return incorrect values. Here is a
> sequence of operations that will reproduce the problem:
> # A KeyValue is created whose key has length 10. The private field keyLength
> is initialized to 0.
> # KeyValue.getKeyLength() is called. This reads the key length 10 from the
> backing array and caches it in keyLength.
> # KeyValue.readFields() is called to deserialize a new value. The keyLength
> field is not cleared and keeps its value of 10, even though this value is
> probably incorrect.
> # If getKeyLength() is called, the value 10 will be returned.
> For example, in a reducer with Iterable<KeyValue>, all values after the first
> one from the iterable are likely to return incorrect values from
> getKeyLength().
> The solution is to clear all memoized values in KeyValue.readFields(). I'll
> write a patch for this soon.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
