[
https://issues.apache.org/jira/browse/HBASE-28705?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nick Dimiduk updated HBASE-28705:
---------------------------------
Resolution: Fixed
Status: Resolved (was: Patch Available)
This is pushed to branch-2.6+. Thanks a lot [~dieterdp_ng] for the fix and your
patient explanations.
> BackupLogCleaner cleans required WALs when using multiple backuproots
> ---------------------------------------------------------------------
>
> Key: HBASE-28705
> URL: https://issues.apache.org/jira/browse/HBASE-28705
> Project: HBase
> Issue Type: Bug
> Components: backup&restore
> Affects Versions: 2.6.0, 3.0.0
> Reporter: Dieter De Paepe
> Assignee: Dieter De Paepe
> Priority: Blocker
> Labels: pull-request-available
> Fix For: 2.7.0, 3.0.0-beta-2, 2.6.1
>
>
> The BackupLogCleaner is responsible for avoiding the deletion of WAL/logs
> that still need to be included in a future backup.
> The logic to decide which files can be deleted does not work correctly when
> multiple backup roots are used. Each backup root has a different chain of
> backups (full, incremental1, incremental2, ...). So, if any chain requires a
> log, it should be preserved. This is not the case.
> The result is that logs could be incorrectly deleted, resulting in data loss
> in backups.
> PR incoming with test & fix.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
