NihalJain commented on code in PR #6184:
URL: https://github.com/apache/hbase/pull/6184#discussion_r1799303394


##########
bin/hbase:
##########
@@ -766,13 +767,6 @@ elif [ "$COMMAND" = "copyreppeers" ] ; then
   CLASS='org.apache.hadoop.hbase.replication.CopyReplicationPeers'
 else
   CLASS=$COMMAND
-if [[ "$CLASS" =~ .*IntegrationTest.* ]] ; then

Review Comment:
   Okay so basic we want to retain the 3 files under HBASE_HOME/lib/test i.e.
   
   - hamcrest-core-1.3.jar
   - junit-4.13.2.jar
   - mockito-core-4.11.0.jar
   
   Let me make this change and figure out if we can still run IT by building 
from source.



##########
bin/hbase:
##########
@@ -766,13 +767,6 @@ elif [ "$COMMAND" = "copyreppeers" ] ; then
   CLASS='org.apache.hadoop.hbase.replication.CopyReplicationPeers'
 else
   CLASS=$COMMAND
-if [[ "$CLASS" =~ .*IntegrationTest.* ]] ; then

Review Comment:
   Okay so basically we want to retain the 3 files under HBASE_HOME/lib/test 
i.e.
   
   - hamcrest-core-1.3.jar
   - junit-4.13.2.jar
   - mockito-core-4.11.0.jar
   
   Let me make this change and figure out if we can still run IT by building 
from source.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to