NihalJain commented on code in PR #6366:
URL: https://github.com/apache/hbase/pull/6366#discussion_r1800974758
##########
pom.xml:
##########
@@ -925,13 +916,11 @@
<lz4.version>1.8.0</lz4.version>
<snappy.version>1.1.10.4</snappy.version>
<zstd-jni.version>1.5.5-2</zstd-jni.version>
- <!--
- Note that the version of protobuf shipped in hbase-thirdparty must
match the version used
- in hbase-protocol-shaded and hbase-examples. The version of
jackson-[annotations,core,
- databind] must be kept in sync with the version of
jackson-jaxrs-json-provider shipped in
- hbase-thirdparty.
+ <hbase-thirdparty.version>4.1.10-SNAPSHOT</hbase-thirdparty.version>
+ <!--Version of protobuf that hbase uses internally (we shade our pb)
+ Must match what is out in hbase-thirdparty include.
Review Comment:
Could not remove the hardcoding of internal.protobuf.version as with BOM
seems its not possible to pass on properties. And we actually use the protobuf
version property in our code in `protobuf-maven-plugin` plugin
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
