vinayakphegde commented on code in PR #6373:
URL: https://github.com/apache/hbase/pull/6373#discussion_r1820099784
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/BucketCache.java:
##########
@@ -130,6 +131,11 @@ public class BucketCache implements BlockCache, HeapSize {
private static final String STRONG_REF_KEY =
"hbase.bucketcache.offsetlock.usestrongref";
private static final boolean STRONG_REF_DEFAULT = false;
+ /** The cache age of blocks to check if the related file is present on any
online regions. */
+ static final String BLOCK_ORPHAN_GRACE_PERIOD =
"hbase.bucketcache.block.orphan.evictgraceperiod";
Review Comment:
nit: Since this configuration is in seconds, can we define it directly in
the config, as we usually do? Something like
`"hbase.bucketcache.block.orphan.evictgraceperiod.seconds"`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
