stoty commented on code in PR #6361:
URL: https://github.com/apache/hbase/pull/6361#discussion_r1821914014
##########
hbase-client/src/main/java/org/apache/hadoop/hbase/filter/PrefixFilter.java:
##########
@@ -142,6 +165,28 @@ boolean areSerializedFieldsEqual(Filter o) {
return Bytes.equals(this.getPrefix(), other.getPrefix());
}
+ @Override
Review Comment:
Let's move these before the serialization-realted methods, so that the real
logic is together,
##########
hbase-client/src/main/java/org/apache/hadoop/hbase/filter/PrefixFilter.java:
##########
@@ -142,6 +165,28 @@ boolean areSerializedFieldsEqual(Filter o) {
return Bytes.equals(this.getPrefix(), other.getPrefix());
}
+ @Override
+ public Cell getNextCellHint(Cell cell) {
+ if (reversed) {
+ return reversedNextCellHint;
+ } else {
+ // On forward scan hint should be the prefix
+ return PrivateCellUtil.createFirstOnRow(prefix, 0, (short)
prefix.length);
Review Comment:
Pre-compute this one, too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
