NihalJain commented on code in PR #6184:
URL: https://github.com/apache/hbase/pull/6184#discussion_r1831036039
##########
hbase-assembly/pom.xml:
##########
@@ -48,13 +48,17 @@
<artifactId>hbase-shaded-mapreduce</artifactId>
</dependency>
<!-- Intra-project dependencies -->
+ <!-- We don't really add this to assembly tarball, we retain it here just
to dump it into
Review Comment:
Sorry lost momentum here.
> What about adding a new module which is used only for generating
cached-classpath instead ?
Or maybe using hbase-it, IF that already has all the dependencies we need
for cached-classpath ?
I could try generating cached-classpath for hbase-it, only thing is with
current change we are able to ensure there is no cached-classpath change for
code run via source directory even after this PR.
Adding a new module just for cached-classpath sounds an overkill and will
have issues with keeping pom.xml in sync.
But is not assembly's pom.xml for the same purpose? I mean I am not sure if
current change is a hack since we maintain jars in assembly's pom.xml for
generating classpath. For example we already have:
```
<!-- To dump tools in hbase-procedure into cached_classpath.txt. -->
<dependency>
<groupId>org.apache.hbase</groupId>
<artifactId>hbase-procedure</artifactId>
</dependency>
```
Assembly is anyways controlled via the *.xml's!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
