[ 
https://issues.apache.org/jira/browse/HBASE-6372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13429020#comment-13429020
 ] 

Shengsheng Huang commented on HBASE-6372:
-----------------------------------------

It seems the current Scan#setBatch function may throw exception. Details as 
below:
{quote}
public void setBatch(int batch) {
    if (this.hasFilter() && this.filter.hasFilterRow()) {
      throw new IncompatibleFilterException(
        "Cannot set batch on a scan using a filter" +
        " that returns true for filter.hasFilterRow");
    }
    this.batch = batch;
  }
{quote}
Don't we need to catch that exception in this patch? 

                
> Add scanner batching to Export job
> ----------------------------------
>
>                 Key: HBASE-6372
>                 URL: https://issues.apache.org/jira/browse/HBASE-6372
>             Project: HBase
>          Issue Type: Improvement
>          Components: mapreduce
>    Affects Versions: 0.96.0, 0.94.2
>            Reporter: Lars George
>            Assignee: Shengsheng Huang
>            Priority: Minor
>              Labels: newbie
>         Attachments: HBASE-6372.2.patch, HBASE-6372.3.patch, 
> HBASE-6372.4.patch, HBASE-6372.patch
>
>
> When a single row is too large for the RS heap then an OOME can take out the 
> entire RS. Setting scanner batching in custom scans helps avoiding this 
> scenario, but for the supplied Export job this is not set.
> Similar to HBASE-3421 we can set the batching to a low number - or if needed 
> make it a command line option.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to