shubham-roy commented on code in PR #6435:
URL: https://github.com/apache/hbase/pull/6435#discussion_r1832636865
##########
hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapreduce/RowCounter.java:
##########
@@ -65,22 +68,42 @@ public class RowCounter extends AbstractHBaseTool {
private final static String OPT_END_TIME = "endtime";
private final static String OPT_RANGE = "range";
private final static String OPT_EXPECTED_COUNT = "expectedCount";
+ private final static String OPT_COUNT_DELETE_MARKERS = "countDeleteMarkers";
private String tableName;
private List<MultiRowRangeFilter.RowRange> rowRangeList;
private long startTime;
private long endTime;
private long expectedCount;
+ private boolean countDeleteMarkers;
private List<String> columns = new ArrayList<>();
+ private Job job;
Review Comment:
@NihalJain, the method `runCreateSubmittableJobWithArgs` internally calls
`RowCounter.createSubmittableJob(TEST_UTIL.getConfiguration(), args)`. However,
the method `createSubmittableJob` is marked for deprecation - [code
link](https://github.com/apache/hbase/blob/40d9e9db776203cdb6ccf2dacebe7503c68bd79c/hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapreduce/RowCounter.java#L142).
So ideally, I believe (please correct me if I am wrong), we should not be
making a change to that method. To use that method, we have to change the scan
behaviour based on the flag.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
