guluo2016 commented on PR #6461: URL: https://github.com/apache/hbase/pull/6461#issuecomment-2478475305
By default, this test case will not be executed because this test class is annotated with `@Ignore`. https://github.com/apache/hbase/blob/master/hbase-mapreduce/src/test/java/org/apache/hadoop/hbase/snapshot/TestExportSnapshot.java#L77L83 ```java @Ignore // HBASE-24493 @Category({ VerySlowMapReduceTests.class, LargeTests.class }) public class TestExportSnapshot { ``` Removing this annotation, I find that testExportFileSystemStateWithSplitRegion() can still pass even without any code modifications for ExportSnapshot.java. Do we need a test case that will fail without these changes? ```shell WARNING: System::setSecurityManager will be removed in a future release [INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 403.528 s - in org.apache.hadoop.hbase.snapshot.TestExportSnapshot [INFO] [INFO] Results: [INFO] [INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0 [INFO] [INFO] [INFO] --- surefire:3.1.0:test (secondPartTestsExecution) @ hbase-mapreduce --- [INFO] Tests are skipped. [INFO] ------------------------------------------------------------------------ [INFO] Reactor Summary for Apache HBase 4.0.0-alpha-1-SNAPSHOT: [INFO] [INFO] Apache HBase ....................................... SUCCESS [ 1.482 s] [INFO] Apache HBase - Checkstyle .......................... SUCCESS [ 0.338 s] [INFO] Apache HBase - Annotations ......................... SUCCESS [ 0.782 s] [INFO] Apache HBase - Build Configuration ................. SUCCESS [ 0.078 s] [INFO] Apache HBase - Logging ............................. SUCCESS [ 0.895 s] [INFO] Apache HBase - Shaded Protocol ..................... SUCCESS [ 27.518 s] [INFO] Apache HBase - Common .............................. SUCCESS [ 8.899 s] [INFO] Apache HBase - Metrics API ......................... SUCCESS [ 1.582 s] [INFO] Apache HBase - Metrics Implementation .............. SUCCESS [ 1.486 s] [INFO] Apache HBase - Hadoop Compatibility ................ SUCCESS [ 3.432 s] [INFO] Apache HBase - Client .............................. SUCCESS [ 8.250 s] [INFO] Apache HBase - Zookeeper ........................... SUCCESS [ 2.315 s] [INFO] Apache HBase - Replication ......................... SUCCESS [ 2.088 s] [INFO] Apache HBase - Balancer ............................ SUCCESS [ 3.520 s] [INFO] Apache HBase - Resource Bundle ..................... SUCCESS [ 0.103 s] [INFO] Apache HBase - HTTP ................................ SUCCESS [ 4.879 s] [INFO] Apache HBase - Asynchronous FileSystem ............. SUCCESS [ 3.958 s] [INFO] Apache HBase - Procedure ........................... SUCCESS [ 2.904 s] [INFO] Apache HBase - Server .............................. SUCCESS [ 41.712 s] [INFO] Apache HBase - MapReduce ........................... SUCCESS [06:51 min] [INFO] ------------------------------------------------------------------------ [INFO] BUILD SUCCESS ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
