[
https://issues.apache.org/jira/browse/HBASE-6518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13429398#comment-13429398
]
stack commented on HBASE-6518:
------------------------------
+1 on the patch.
In future, you don't need to catch the exception and then fail... just let it
out... that'll fail the test
{code}
+ } catch (StringIndexOutOfBoundsException ex) {
+ fail("Illegal string access: " + ex.getMessage());
+ }
{code}
Also, we put spaces around operators in our code. See the rest of the code.
Let me run this by the hadoopqa to see if it passes....
> Bytes.toBytesBinary() incorrect trailing backslash escape
> ---------------------------------------------------------
>
> Key: HBASE-6518
> URL: https://issues.apache.org/jira/browse/HBASE-6518
> Project: HBase
> Issue Type: Bug
> Components: util
> Reporter: Tudor Scurtu
> Assignee: Tudor Scurtu
> Priority: Trivial
> Labels: patch
> Attachments: HBASE-6518.patch
>
>
> Bytes.toBytesBinary() converts escaped strings to byte arrays. When
> encountering a '\' character, it looks at the next one to see if it is an
> 'x', without checking if it exists.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
