bbeaudreault commented on code in PR #6501:
URL: https://github.com/apache/hbase/pull/6501#discussion_r1863520583
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/namespace/NamespaceStateManager.java:
##########
@@ -119,7 +127,7 @@ synchronized void
checkAndUpdateNamespaceRegionCount(TableName name, int incr)
(currentStatus.getRegionCount() - regionCountOfTable + incr)
> TableNamespaceManager.getMaxRegions(nspdesc)
) {
- throw new QuotaExceededException("The table " + name.getNameAsString()
+ throw new QuotaExceededException("The table {}" +
name.getNameAsString()
Review Comment:
This change doesn't work for exception message. Would be cool if it did!
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/namespace/NamespaceStateManager.java:
##########
@@ -186,6 +197,9 @@ void deleteNamespace(String namespace) {
}
private void addTable(TableName tableName, int regionCount) throws
IOException {
+ if (tableName.isSystemTable()) {
Review Comment:
If these add/remove private methods are only called by the others, we may
not need to add the check here since we already guard the callers. But I didn't
trace all the calls and also the redundancy is not a huge issue. Just calling
it out.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
