rmdmattingly commented on code in PR #6294:
URL: https://github.com/apache/hbase/pull/6294#discussion_r1867746210
##########
hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/mapreduce/MapReduceBackupMergeJob.java:
##########
@@ -228,13 +228,15 @@ protected void copyMetaData(FileSystem fs, Path
tmpBackupDir, Path backupDirPath
if (
fileName.indexOf(FSTableDescriptors.TABLEINFO_DIR) > 0
|| fileName.indexOf(HRegionFileSystem.REGION_INFO_FILE) > 0
+ || fileName.indexOf(BackupManifest.MANIFEST_FILE_NAME) > 0
Review Comment:
Good question, this was confusing to me too. Before we stripped the root
directory from the BackupImage, rewriting the manifest would implicitly always
use the original root directory. So this only worked _because_ we were unable
to relocate backups
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
