NihalJain commented on code in PR #6519:
URL: https://github.com/apache/hbase/pull/6519#discussion_r1872644185
##########
hbase-assembly/src/main/assembly/client.xml:
##########
@@ -104,24 +56,44 @@
<dependencySets>
<dependencySet>
- <outputDirectory>lib/shaded-clients</outputDirectory>
- <includes>
- <include>org.apache.hbase:hbase-shaded-client</include>
- <include>org.apache.hbase:hbase-shaded-mapreduce</include>
- <include>org.apache.hbase:hbase-shaded-client-byo-hadoop</include>
- </includes>
+ <outputDirectory>lib</outputDirectory>
+ <useTransitiveDependencies>true</useTransitiveDependencies>
+ <excludes>
+ <!-- Exclude the shaded jars that go in the lib/shaded-clients
directory -->
+ <exclude>org.apache.hbase:hbase-shaded-client</exclude>
+ <exclude>org.apache.hbase:hbase-shaded-mapreduce</exclude>
+ <exclude>org.apache.hbase:hbase-shaded-client-byo-hadoop</exclude>
+ <!-- Exclude the Ruby jar that goes in the lib/ruby directory -->
+ <exclude>org.jruby:jruby-complete</exclude>
+ <!-- Exclude jars that go into the lib/client-facing-thirdparty
directoy -->
+ <exclude>com.github.stephenc.findbugs:findbugs-annotations</exclude>
Review Comment:
so the exclude block should be kept in sync with any dependencies we add in
a sub folder of lib. may be add a note somewhere to avoid dependencies getting
duplicated?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
