NihalJain commented on PR #6519: URL: https://github.com/apache/hbase/pull/6519#issuecomment-2522225029
Is there any difference between tarball generated with this change and without this change? If both are same, a +1 from me, as long as we all are fine to move to use only DependencySets, this is lot cleaner and avoids mixing up. Although it is important to note that this step comes with a extra maintenance step of excluding any non base folder directory jar. Although I am fine with this given we barely add new sub folders and we already plan to add a note in code to notify devs to take care of this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
