Re: [PR] HBASE-28832 Upgrade from bootstrap 3.4.1 to non vulnerable version 5.3.3 [hbase]

Mon, 09 Dec 2024 00:01:42 -0800 


PDavid commented on PR #6490:
URL: https://github.com/apache/hbase/pull/6490#issuecomment-2527194522

   > Hi @PDavid I have reviewed the updated pages and also had a look at REST 
and THRIFT pages. All looks good to me.
   > 
   > Just a NIT: Can we fix this? I see two lines in all table boundaries. For 
eg:
   > 
   > 1. ![Screenshot 2024-12-09 at 12 57 39 
PM](https://private-user-images.githubusercontent.com/3429351/393741541-dbaa6404-ecbd-4afd-b50e-f4f22e24a6f4.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzM3MzEzODQsIm5iZiI6MTczMzczMTA4NCwicGF0aCI6Ii8zNDI5MzUxLzM5Mzc0MTU0MS1kYmFhNjQwNC1lY2JkLTRhZmQtYjUwZS1mNGYyMmUyNGE2ZjQucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MTIwOSUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDEyMDlUMDc1ODA0WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9MGZkMmI4MWU1ZGExNzMzMTY0ZmZlNjcxMzkxNjdlYTE4YWRiNGZlMmQwZmFiNTcwODJkYzFhMGMzYTEwNzM2YiZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QifQ.H-LDBtTWSoT8_8AxVvlGrYCRII16rxCbt89zGlRqkbQ)
   > 
   > 2. ![Screenshot 2024-12-09 at 12 57 32 
PM](https://private-user-images.githubusercontent.com/3429351/393741769-58f7b98f-ae36-465a-90a7-012965c83975.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzM3MzEzODQsIm5iZiI6MTczMzczMTA4NCwicGF0aCI6Ii8zNDI5MzUxLzM5Mzc0MTc2OS01OGY3Yjk4Zi1hZTM2LTQ2NWEtOTBhNy0wMTI5NjVjODM5NzUucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MTIwOSUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDEyMDlUMDc1ODA0WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9N2Q4NTMyY2EyZWJlMGI0ZGYzNzE0OTdjNDBjYWY0NDgwMzM5NDU3NDllNDJhMGY0NjNiYWM2MTk4Y2JiN2Q2OCZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QifQ.K0zGWvCEnfmzARAo6AuwnhQnxaJ9tDkWrSevt5BrUyY)
   > 
   > Can be fixed by replacing with `border-style: solid` with `border-top: 1px 
solid #ddd;`? ![Screenshot 2024-12-09 at 12 53 08 
PM](https://private-user-images.githubusercontent.com/3429351/393740845-a56dc446-241d-4f34-bd48-e2fc1193852d.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzM3MzEzODQsIm5iZiI6MTczMzczMTA4NCwicGF0aCI6Ii8zNDI5MzUxLzM5Mzc0MDg0NS1hNTZkYzQ0Ni0yNDFkLTRmMzQtYmQ0OC1lMmZjMTE5Mzg1MmQucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MTIwOSUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDEyMDlUMDc1ODA0WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9NmM0OTQ0YmIwNTE4ZTdiMDIyMjQ5Mjc1NTZiNTRmZWZiZWYxYWJjMTc3ZjkxMGZiMDY2YzNkZTA3OGUyOTQzNyZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QifQ.Jo4MmmcyU0lQNsjNw2psLn15Ate4o-fN9ZC5d2SBJ2s)
   > 
   > Not important though, you can decide if you would want to fix.
   
   Hi @NihalJain!
   
   Thanks for the detailed checks and the suggestion. :+1: 
   I'll have a look and fix this.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to