stoty commented on code in PR #6519:
URL: https://github.com/apache/hbase/pull/6519#discussion_r1875700679
##########
hbase-assembly/pom.xml:
##########
@@ -245,20 +211,36 @@
<groupId>io.opentelemetry.javaagent</groupId>
<artifactId>opentelemetry-javaagent</artifactId>
</dependency>
- <!-- We don't really add this to assembly tarball, we retain it here just
to dump it into
- cached_classpath.txt ! See HBASE-28433 for more info. -->
+ <!-- This is an optional dependency of hbase-external-blockcache.
Review Comment:
I took another look at this.
I guess that the original intent was to NOT include it in the assembly, it
just got lost somehow.
The last version is also from 2017, so this doesn't look a maintaned library.
Based on the comments, getting this right is far from trivial, and this
probably has few users, so it might be better to keep it optional, and just
leave it out from assembly.
That way most users will get less JARs, and the few (if any) users of it
would have to provide it themselves.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
