anmolnar commented on code in PR #6507:
URL: https://github.com/apache/hbase/pull/6507#discussion_r1876874247
##########
hbase-asyncfs/src/main/java/org/apache/hadoop/hbase/io/asyncfs/FanOutOneBlockAsyncDFSOutputSaslHelper.java:
##########
@@ -502,12 +507,17 @@ private void checkSaslComplete() throws IOException {
Set<String> requestedQop =
ImmutableSet.copyOf(Arrays.asList(saslProps.get(Sasl.QOP).split(",")));
String negotiatedQop = getNegotiatedQop();
+ // Treat null negotiated QOP as "auth" for the purpose of verification
+ // Code elsewhere does the same implicitly
+ if (negotiatedQop == null) {
+ negotiatedQop = "auth";
+ }
Review Comment:
I don't see why is this necessary here. It's only effective within this
private method and doesn't make any difference in the verification at line 517,
while it hides that there was no negotiated QoP with the client.
Since rest of the code handles "auth" and null equally, it'd make sense to
return "auth" by the `getNegotiatedQop()` if null was negotiated effectively
making sure that negotiatedQop will never be null. That would probably make
some of the code in this class simpler, but still not strictly required for
this patch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
