Reidddddd commented on code in PR #6532:
URL: https://github.com/apache/hbase/pull/6532#discussion_r1881496578
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSourceWALActionListener.java:
##########
@@ -38,14 +41,24 @@ class ReplicationSourceWALActionListener implements
WALActionsListener {
private final ReplicationSourceManager manager;
+ private final boolean filterWALByReplicationScope;
+
public ReplicationSourceWALActionListener(Configuration conf,
ReplicationSourceManager manager) {
this.conf = conf;
this.manager = manager;
+ this.filterWALByReplicationScope =
+ conf.getBoolean(REPLICATION_WAL_FILTER_BY_SCOPE_ENABLED,
REPLICATION_WAL_FILTER_BY_SCOPE_ENABLED_DEFAULT);
}
@Override
public void postLogRoll(Path oldPath, Path newPath) throws IOException {
- manager.postLogRoll(newPath);
+ if (filterWALByReplicationScope) {
+ if (AbstractFSWALProvider.isFileInReplicationScope(newPath)) {
Review Comment:
could simply combine two conditions via `&&`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
