PDavid commented on PR #6490: URL: https://github.com/apache/hbase/pull/6490#issuecomment-2538633856
> > Prepared backport PR-s for the active branches here: > > > > * branch-2: [HBASE-28832 Upgrade from bootstrap 3.4.1 to non vulnerable version 5.3.3 #6524](https://github.com/apache/hbase/pull/6524) > > * branch-2.5: [HBASE-28832 Upgrade from bootstrap 3.4.1 to non vulnerable version 5.3.3 #6525](https://github.com/apache/hbase/pull/6525) > > * branch-2.6: [HBASE-28832 Upgrade from bootstrap 3.4.1 to non vulnerable version 5.3.3 #6526](https://github.com/apache/hbase/pull/6526) > > * branch-3: [HBASE-28832 Upgrade from bootstrap 3.4.1 to non vulnerable version 5.3.3 #6527](https://github.com/apache/hbase/pull/6527) > > Hi @PDavid thanks for all the backports, would be really helpful if you could mention the why the diffs are substantially smaller in branch-2.x vs master, a brief summary should suffice mentioning any extra/missing changes worth reviewing over there Hi @NihalJain, Sure thing, thanks. So in the branch-2.x branches the web code is a bit different (I think some patches were not merged there in the past). Differences are for example: - in some of the branch-2.x branches there are no `header.jsp` / `footer.jsp` in `hbase-rest` and `hbase-thrift` (or they are there for rest but not for thrift, etc) - there is no `processRest.jsp` - navbars do not contain the dropdown for Prometheus links. - also `table.jsp` was a little bit different - for example most of those imports which were unused on master were still used on branch-2.x So because the web code was different, when I cherry-picked my commits I had to adapt the changes. I hope this answers your question. :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
