Apache9 commented on PR #6534:
URL: https://github.com/apache/hbase/pull/6534#issuecomment-2547422193

   What about add a new step after acquire worker to rename the wal file, where 
we just append the worker's name to the wal file name as suffix?
   
   And we need to be very careful when dealing with retrying...
   
   There are several problems currently
   
   1. Renaming failure does not always mean the old file is still there, maybe 
the renaming is complete but we just do not get the result because of a network 
issue, then in the current code we will consider the splitting as finished and 
cause data loss.
   2. We will do the renaming after release worker, if the renaming fails, when 
retrying we will release the worker again, this will cause  trouble...


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to