anmolnar commented on PR #6381: URL: https://github.com/apache/hbase/pull/6381#issuecomment-2557497863
> > Sorry for coming back too late here. Quick question: why have you replaced the WatchService implementation instead of introducing the polling mechanism as a new and configurable option? > > No worries. My preference is for less code that Just Works for all use cases. My hope is that this PR will accomplish that. I don't think there is value in keeping a second implementation if there's not a clear reason to keep it. I agree with that, but isn't `WatchService` more efficient? It's based on inotify in Linux and wakes up the thread when event comes instead, instead of polling the FS in every minute. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
