guluo2016 commented on code in PR #6556:
URL: https://github.com/apache/hbase/pull/6556#discussion_r1895654326
##########
hbase-server/src/main/resources/hbase-webapps/regionserver/processRS.jsp:
##########
@@ -68,8 +70,8 @@ pageContext.setAttribute("pageTitle", "Process info for PID:
" + JSONMetricUtil.
<td><%= new Date(runtimeBean.getStartTime()) %></td>
<td><%= StringUtils.humanTimeDiff(runtimeBean.getUptime()) %></td>
<td><%= JSONMetricUtil.getProcessPID() %></td>
- <td><%= (long)JSONMetricUtil.getValueFromMBean(rsMetrics,
"pauseWarnThresholdExceeded")
- + (long)JSONMetricUtil.getValueFromMBean(rsMetrics,
"pauseInfoThresholdExceeded") %></td>
+ <td><%= pauseWarnThresholdExceeded != null &&
pauseInfoThresholdExceeded != null ?
+ (long)pauseWarnThresholdExceeded +
(long)pauseInfoThresholdExceeded : -1 %></td>
Review Comment:
Is it better to display 0 if it's null? I'm not sure, maybe we can hear
other people's opinions?
`<th>JvmPauseMonitor Count </th>` , Can you also remove this space in line65?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
