NihalJain commented on code in PR #6366:
URL: https://github.com/apache/hbase/pull/6366#discussion_r1896680290
##########
pom.xml:
##########
@@ -925,13 +916,11 @@
<lz4.version>1.8.0</lz4.version>
<snappy.version>1.1.10.4</snappy.version>
<zstd-jni.version>1.5.5-2</zstd-jni.version>
- <!--
- Note that the version of protobuf shipped in hbase-thirdparty must
match the version used
- in hbase-protocol-shaded and hbase-examples. The version of
jackson-[annotations,core,
- databind] must be kept in sync with the version of
jackson-jaxrs-json-provider shipped in
- hbase-thirdparty.
+ <hbase-thirdparty.version>4.1.10-SNAPSHOT</hbase-thirdparty.version>
+ <!--Version of protobuf that hbase uses internally (we shade our pb)
+ Must match what is out in hbase-thirdparty include.
Review Comment:
>Maven load project model (from pom.xml) for project and all submodules at
startup time. During project reading all available properties are resolved from
projects and settings properties.
>
>This plugin (as all other) is executed in the later phase - when project
model is already build in memory.
>
>So properties read from external files by this plugin can not by used in
project definitions in items like <goal>, <version> and so on.
https://www.mojohaus.org/properties-maven-plugin/#plugin-limitations
https://github.com/mojohaus/properties-maven-plugin/issues/26
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
