junegunn commented on code in PR #6559:
URL: https://github.com/apache/hbase/pull/6559#discussion_r1897626459
##########
hbase-mapreduce/src/test/java/org/apache/hadoop/hbase/PerformanceEvaluation.java:
##########
@@ -1149,7 +1149,7 @@ private static long nextRandomSeed() {
return randomSeed.nextLong();
}
- private final int everyN;
+ private final long everyN;
protected final Random rand = new Random(nextRandomSeed());
Review Comment:
> to minimize the required code change
`generateData` is used in other places, but without a custom seed value.
https://github.com/apache/hbase/blob/fd11b9bfcf2074ff0910ca1278f8a2fb66f0ad58/hbase-mapreduce/src/test/java/org/apache/hadoop/hbase/mapreduce/TestCellBasedHFileOutputFormat2.java#L508-L518
https://github.com/apache/hbase/blob/b7def4ff9b98164152ea4ccff6206bfe3d17bac6/hbase-mapreduce/src/test/java/org/apache/hadoop/hbase/mapreduce/TestHFileOutputFormat2.java#L545-L555
So it's actually trivial to remove the Random parameter altogether.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
