terrytlu commented on code in PR #6259:
URL: https://github.com/apache/hbase/pull/6259#discussion_r1900872041
##########
hbase-hadoop-compat/src/main/java/org/apache/hadoop/hbase/regionserver/wal/MetricsWALSourceImpl.java:
##########
@@ -88,7 +88,7 @@ public void incrementAppendSize(TableName tableName, long
size) {
if (tableAppendSizeCounter == null) {
// Ideally putIfAbsent is atomic and we don't need a branch check but we
still do it to avoid
// expensive string construction for every append.
- String metricsKey = String.format("%s.%s", tableName, APPEND_SIZE);
+ String metricsKey = String.format("%s.%s",
tableName.getMetricPrefixTableName(), APPEND_SIZE);
Review Comment:
Sorry for the late reply, I tried jmxterm tool, found we could get this
metric correctly 😂 ...
Also found this issue already fixed
https://issues.apache.org/jira/browse/HBASE-26745, I will close this issue as
it is duplicated and already fixed by HBASE-26745.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
