PDavid commented on PR #6551: URL: https://github.com/apache/hbase/pull/6551#issuecomment-2572800297
Hi @NihalJain and @Apache9, Many thanks for your reviews and tests. :pray: Sorry, I was completely off in the holiday season. > 1. [HBASE-24624](https://issues.apache.org/jira/browse/HBASE-24624) Optimize table.jsp code: TODO > > * This change is huge wrt to original PR, @PDavid could you summarise what all we changed here? Is there a whitespace issue? Mind fixing it? Or are you doing this to align with Master? The motivation behind these backport UI changes PR-s (and this specific backport you mention) is to align with master branch so that the Boostrap upgrade can be backported more cleanly. Here the problem was that - if you check the history of table.jsp on master branch and on branch-2 - that this "Optimize table.jsp code" patch was missing from branch-2 but the newer patches were applied (backported) on branch-2. This made table.jsp quite different than it was when "Optimize table.jsp code" patch was merged to master branch. So when I backported this change I was extra careful to not to "undo" the changes which newer backported patches did. > Also could you please summarise how the changes have been tested. Sure. I built the project in dev mode with `mvn clean install -DskipTests -Dhadoop.profile=3.0` then started HBase locally with `bin/start-hbase.sh` in standalone mode. Created some tables with some rows and checked the Master UI, region server UI. Started Thrift server (`bin/hbase thrift start -p 8081`) and REST server (`bin/hbase rest start -p 8080`) and checked their UI respectively. To properly verify the REST UI I had to copy the `static` resources folder under `hbase-rest/src/main/resources/hbase-webapps` folder because of the REST UI is broken (static resources are not loaded) https://issues.apache.org/jira/browse/HBASE-28983 issue - but this change I did not committed as there is a separate Jira. Hope this answers your question. Any suggestions maybe in regards to testing? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
