PDavid commented on code in PR #6585: URL: https://github.com/apache/hbase/pull/6585#discussion_r1908761825
########## hbase-server/src/main/resources/hbase-webapps/master/procedures.jsp: ########## @@ -18,32 +18,20 @@ */ --%> <%@ page contentType="text/html;charset=UTF-8" - import="static org.apache.commons.lang3.StringEscapeUtils.escapeXml" + import="static org.apache.commons.text.StringEscapeUtils.escapeXml10" Review Comment: @NihalJain Sorry, can I ask why shouldn't we use commons-text here? > I don't even see commons-text as a direct dependency to hbase. That's a good point, thanks. :+1: I guess commons-text is not a direct dependency to hbase but a transitive one. If required we can add it as a direct dependency. > We should replace with org.apache.commons.lang3.StringEscapeUtils.escapeXml10, isn't it?[apache/commons-lang@`29ccc76`/src/main/java/org/apache/commons/lang3/StringEscapeUtils.java#L618](https://github.com/apache/commons-lang/blob/29ccc7665f3bc5d84155a3092ab2209a053324e6/src/main/java/org/apache/commons/lang3/StringEscapeUtils.java#L618) As you may see in the JavaDoc of [org.apache.commons.lang3.StringEscapeUtils](https://commons.apache.org/proper/commons-lang/apidocs/org/apache/commons/lang3/StringEscapeUtils.html), it says: > As of 3.6, use Apache Commons Text [StringEscapeUtils](https://commons.apache.org/proper/commons-text/javadocs/api-release/org/apache/commons/text/StringEscapeUtils.html) instead So the whole `org.apache.commons.lang3.StringEscapeUtils` class is deprecated. Also according to [this StackOverflow answer](https://stackoverflow.com/a/49647538/9369409), this `StringEscapeUtils` class was moved over to commons-text but still kept as deprecated in commons-lang3. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
