PDavid commented on PR #6585:
URL: https://github.com/apache/hbase/pull/6585#issuecomment-2606565909

   > This looks mostly good to me, my only problem that this does not match the 
JIRA description. At least half of the changes are not in JSPs.
   
   @stoty thanks, this is a very good point. I started with the deprecated 
calls in the JSP-s but then @NihalJain [proposed to also replace the 
same](https://github.com/apache/hbase/pull/6585#discussion_r1922204309) 
`org.apache.hadoop.util.StringUtils.humanReadableInt(long)` call in all places.
   So eventually now we have more changes not in the JSP-s. :see_no_evil: 
   
   Should I maybe revert those changes? Or rename the Jira ticket?
   What do you all think?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to