hgromer commented on code in PR #6623:
URL: https://github.com/apache/hbase/pull/6623#discussion_r1925328746
##########
hbase-client/src/main/java/org/apache/hadoop/hbase/shaded/protobuf/ProtobufUtil.java:
##########
@@ -1434,6 +1439,10 @@ public static ClientProtos.Result toResult(final Result
result, boolean encodeTa
builder.setStale(result.isStale());
builder.setPartial(result.mayHaveMoreCellsInRow());
+ if (result.getMetrics() != null) {
Review Comment:
Throwing an error might be a bit aggressive, though I'd be curious to know
what others think. I'm not sure if we're happy throwing an unchecked exception
from `setCheckExistenceOnly` and if we wanted to throw an `IOException`, we'd
have to change the signature.
Maybe it's enough that the metics returned will be null
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
